Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): support generate echo route based on protobuf #673

Closed
sysulq opened this issue Jan 18, 2023 · 1 comment
Closed

feat(cmd): support generate echo route based on protobuf #673

sysulq opened this issue Jan 18, 2023 · 1 comment

Comments

@sysulq
Copy link
Member

sysulq commented Jan 18, 2023

Issue Description

Type: feature request

goos: linux
goarch: amd64
pkg: github.com/douyu/jupiter/pkg/server/xecho
cpu: Intel(R) Core(TM) i5-10500 CPU @ 3.10GHz
BenchmarkHTTP/HTTP_with_reflect-12                100808             14692 ns/op            9211 B/op         68 allocs/op
BenchmarkHTTP/HTTP_without_reflect-12             145160             13771 ns/op            8184 B/op         56 allocs/op
BenchmarkHTTP/HTTP_with_protojson-12              158428             13072 ns/op            8184 B/op         56 allocs/op
BenchmarkHTTP/HTTP_with_json-12                   265099              4733 ns/op            7448 B/op         34 allocs/op
BenchmarkHTTP/HTTP_with_gateway-12                 74196             36914 ns/op           10735 B/op        102 allocs/op
PASS
coverage: 23.2% of statements
ok      github.com/douyu/jupiter/pkg/server/xecho       10.081s

Consider the benchmark here, we won't use grpc-gateway, and try to simplify the implementation to satisfy current situation.
And maybe standard json should be nice after remove the emitempty from json tag.

Describe what feature you want

Additional context

Add any other context or screenshots about the feature request here.

@sysulq sysulq changed the title feat: support generate echo route based on protobuf feat(cmd): support generate echo route based on protobuf Jan 18, 2023
@sysulq
Copy link
Member Author

sysulq commented Feb 1, 2023

#696

@sysulq sysulq closed this as completed Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant