Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lmtp_add_received_headers bool setting #74

Closed
wants to merge 2 commits into from

Conversation

bjne
Copy link
Contributor

@bjne bjne commented Apr 11, 2018

Add the ability to prevent dovecot/lmtp from adding received
headers. This is useful if one needs to use LMTP, but does
not want additional received headers because:

  1. dovecot does not have correct information to add to the
    headers, and causes misleading/incorrect information
  2. does not want to expose internal information

The default value is true, as current behavior

@sirainen
Copy link
Contributor

At least I'd call it "lmtp_add_received_header" since there's only a single header being added.

@bjne
Copy link
Contributor Author

bjne commented Apr 12, 2018

sirainen: agree, thanks for the input

@bjne
Copy link
Contributor Author

bjne commented May 9, 2018

Please accept, comment or close

@cmouse
Copy link
Contributor

cmouse commented May 10, 2018

Sorry for the delay, we'll try to look at this soon.

@sirainen
Copy link
Contributor

Well, I hate adding new settings, but I guess this can be useful. So mainly:

  • squash the two commits together
  • Include "lmtp: " prefix in the commit message title

@tomsommer
Copy link
Contributor

Big +1 on this. Ping @bjne

@bjoe2k4
Copy link

bjoe2k4 commented Sep 27, 2018

Ping!? @bjne

@bjne
Copy link
Contributor Author

bjne commented Sep 27, 2018

Sorry for the delay. Will fix soon!

Add the ability to prevent dovecot/lmtp from adding received
header. This is useful if one needs to use LMTP, but does
not want additional received headers because:

1) dovecot does not have correct information to add to the
   headers, and causes misleading/incorrect information
2) does not want to expose internal information

The default value is true, as current behavior
@bjne bjne force-pushed the lmtp_add_received_headers branch from 0f53bc8 to df465ae Compare October 2, 2018 12:52
@bjne
Copy link
Contributor Author

bjne commented Oct 2, 2018

@sirainen sorry for the delay, the fixes you requested are done.

@bjne
Copy link
Contributor Author

bjne commented Oct 3, 2018

@tomsommer @bjoe2k4 guess my part is done now, sorry for taking the time

@bjne
Copy link
Contributor Author

bjne commented Oct 17, 2018

@sirainen can you please merge now?

@stephanbosch
Copy link
Contributor

Created internal merge request for this. I am not sure when that will roll out in a release though.

@bjne
Copy link
Contributor Author

bjne commented Nov 22, 2018

@stephanbosch why not just merge it?

@bjne
Copy link
Contributor Author

bjne commented Feb 1, 2019

@sirainen is there any progress here?

@bjoe2k4
Copy link

bjoe2k4 commented Jun 29, 2019

Time flies...

@cmouse
Copy link
Contributor

cmouse commented Jun 29, 2019

So it does, I'll check what's going with this.

@bjoe2k4
Copy link

bjoe2k4 commented Jul 9, 2019

thx

@sirainen
Copy link
Contributor

sirainen commented Jul 9, 2019

merged

@sirainen sirainen closed this Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants