Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/set perms on run #117

Closed
wants to merge 4 commits into from

Conversation

maxfortun
Copy link

Description

Moved user id setting from build time to runtime in order to set writable permissions on config files

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pcmxgti
Copy link
Contributor

pcmxgti commented May 19, 2023

@maxfortun, thank you for this. We ended up taking a slightly different approach to fix this issue. The Dockerfile and documentation changes in #124 should make running on Linux a lot easier. Let us know if it doesn't work for you, and we will look for a different solution.

@pcmxgti pcmxgti closed this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants