Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permission issues with docker mount, and update related documentation #124

Merged
merged 1 commit into from
May 19, 2023

Conversation

pcmxgti
Copy link
Contributor

@pcmxgti pcmxgti commented May 19, 2023

Description

Update Dockerfile and documentation on how to run Tokendito from a Docker container

Motivation and Context

Previous versions of the documentation did not explain clearly how to have read/write mounts on Linux so that Tokendito could update the AWS credentials files

How Has This Been Tested?

Locally on Linux (Ubuntu) and MacOS

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@pcmxgti pcmxgti requested a review from sevignyj May 19, 2023 18:16
@sevignyj sevignyj merged commit 1f17183 into main May 19, 2023
23 checks passed
@pcmxgti pcmxgti mentioned this pull request May 19, 2023
10 tasks
@pcmxgti pcmxgti deleted the fix/docker_usermap branch September 17, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants