Allow funnel token to carry application context information #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzajic
approved these changes
Dec 14, 2016
| @@ -30,14 +30,17 @@ def from_token(token:) | |||
| raise InvalidTokenError, "Invalid token '#{token}': #{e.message}" | |||
| end | |||
|
|
|||
| def build(route_generator:, params: {}, expires_in_days: nil) | |||
| def build(route_generator:, params: {}, expires_in_days: nil, context: {}) | |||
There was a problem hiding this comment.
I think meta is a better name than context here, context maybe should be the key something inside the meta hash...Thinking of the way we could/will use this in the future (tracking, auth, trigger actions, set flash messages etc), it should be a bit more abstract.
I agree that the current app-side implementation of context is a little clunky, ie:
- funnel = Funneler.from_routes(routes: routes)
+ funnel = Funneler.from_routes(routes: routes,
+ context: { funnel_name: Funnels::PendingInvitesStue.name })Default contextual information (like the funnel name) should be added to Funnels::Base and perhaps the more information can be captured here in the constructor, eg, context.reverse_merge!(caller: caller.last)
A funnel can now be generated with extra `meta` information that will be retained through out it's use. This data can be useful for applications wanting to carry around extra information outside of the URL params.
rstawarz
force-pushed
the
rs_allow_funnel_to_cary_context
branch
from
56f4910
to
99f6db2
Compare
chriswoodrich
approved these changes
Dec 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A funnel can now be generated with extra
contextinformation that willbe retained through out it's use. This data can be useful for
applications wanting to carry around extra information outside of the
URL params.