Skip to content

Commit

Permalink
issue #8355 Doxywizard 1.9.x doesn't start up properly
Browse files Browse the repository at this point in the history
The problem here was that the "wizard/loadsetting" key in the registry is set (Using a set of settings defined by the user as a "default" set of settings) in an older version and that some of the keys didn't yet exist in that version but were required in the current version.
So we have to test whether or not the setting is valid and not a default "QVariant" is returned (as this will not have methods required by doxygen ./ there is no value and thus no update necessary and the current value can remain.

Note that the test contains of 2 parts:
- var.isDefault() i.e. whether or not the setting is present in the user "default" settings
- The name of the setting is known but not compiled into the current executable (e.g the SQLITE3 settings of the CLAN settings)

In the past this was, apparently, not necessary (or never noticed / reported).
  • Loading branch information
albert-github committed Jan 1, 2022
1 parent 38ec660 commit facf7a9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion addon/doxywizard/expert.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ void Expert::loadSettings(QSettings *s)
{
i.next();
QVariant var = s->value(SA("config/")+i.key());
if (i.value())
if (i.value() && var.isValid())
{
//printf("Loading key %s: type=%d value='%s'\n",qPrintable(i.key()),var.type(),qPrintable(var.toString()));
i.value()->value() = var;
Expand Down

0 comments on commit facf7a9

Please sign in to comment.