-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rbw sync fails due to a JSON parse error #50
Comments
I should add that I'm running a self-hosted bitwarden-rs as the backend, no idea if it's mangling something. |
I managed a quick and dirty way to dump the json and found the culprit: "PasswordHistory":[{"LastUsedDate":"2021-03-31T19:30:06.936Z","Password":null}] I can find this empty entry in the bitwarden desktop app: Note that I suspect that this was added by rbw itself when I used So I managed to work around the issue using the following patch: diff --git a/src/api.rs b/src/api.rs
index 99e12fd..ac35306 100644
--- a/src/api.rs
+++ b/src/api.rs
@@ -254,7 +254,7 @@ impl SyncResCipher {
.iter()
.map(|entry| crate::db::HistoryEntry {
last_used_date: entry.last_used_date.clone(),
- password: entry.password.clone(),
+ password: entry.password.clone().unwrap_or_else(String::new),
})
.collect()
} else {
@@ -459,7 +459,7 @@ struct SyncResPasswordHistory {
#[serde(rename = "LastUsedDate")]
last_used_date: String,
#[serde(rename = "Password")]
- password: String,
+ password: Option<String>,
} This way the
|
Ah it's actually the same issue: since above I replace the NULL password with an empty string, it then fails when it attempts to decrypt it. So instead I'm going to filter out entries with no password. |
I was having issues accessing my passwords with rbw, I decided to
rbw purge
and resync, but I'm still having a problem synchronizing the database:Seems like a trivial enough fix, but I have no idea how to dump said JSON to figure out why it's not correctly formed.
Since it seems to be the
PasswordHistory
that's having issues I tried purging the history and even regenerating new entries but it still fails.I'm running v1.1.2
The text was updated successfully, but these errors were encountered: