Support UUIDs and URIs in code command #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a864366 changed the implementation of `find_entry` to work on the new `Needle` type, but when calling into it from the `code` subcommand the provided string was only passed as a `Needle::Name` when in fact also UUIDs are allowed. Remedy this by parsing the first argument in the same way as with the `get` command, which also enables passing URIs Signed-off-by: Robert Günzler <r@gnzler.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a864366 changed the implementation of
find_entryto work on the newNeedletype, but when calling into it from thecodesubcommand the provided string was only passed as aNeedle::Namewhenin fact also UUIDs are allowed.
Remedy this by parsing the first argument in the same way as with the
getcommand, which also enables passing URIs
Signed-off-by: Robert Günzler r@gnzler.io