fix: don't panic when piping #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piping stdout to something like `head`, which closes rbw's stdout before it's done writing everything, causes a panic. The panic is circumvented by using `writeln!` instead of `println!` and ignoring the error when it's of kind `BrokenPipe`. Closes doy#79
|
@doy could you take a look at this? |
kpcyrd
approved these changes
Jul 18, 2022
|
@doy ping |
svenstaro
suggested changes
Jul 19, 2022
Comment on lines
+536
to
+537
| // write to stdout but don't panic when pipe get's closed | ||
| // this happens when piping stdout in a shell |
There was a problem hiding this comment.
Suggested change
| // write to stdout but don't panic when pipe get's closed | |
| // this happens when piping stdout in a shell | |
| // Write to stdout but don't panic when pipe gets closed | |
| // which is what happens when piping stdout in a shell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piping stdout to something like
head, which closes rbw's stdout beforeit's done writing everything, causes a panic.
The panic is circumvented by using
writeln!instead ofprintln!andignoring the error when it's of kind
BrokenPipe.Closes #79