Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show type of custom field #89

Closed
wants to merge 1 commit into from
Closed

Show type of custom field #89

wants to merge 1 commit into from

Conversation

fdw
Copy link

@fdw fdw commented Apr 30, 2022

This adds some code to get the type of a custom field and to display it. However, some fine-tuning is probably necessary...

Issue: #67

@fdw
Copy link
Author

fdw commented Jan 4, 2024

Hey @doy, are you still interested in this PR?

@fdw
Copy link
Author

fdw commented Apr 28, 2024

This PR is now about two years old, with no reaction from you, @doy. If you are interested in it, please tell me, otherwise I'll close the PR.

@doy
Copy link
Owner

doy commented May 9, 2024

sorry about that - i had assumed that it being in draft meant you were still working on it. honestly, i'd rather see this sort of functionality covered by the json output rather than include it in the default output, because it's not usually that relevant - is there something specific you're interested in here?

@fdw
Copy link
Author

fdw commented May 9, 2024

Including it in the JSON output would be fine for me too - I think this PR draft predates JSON 😉

However, it's not there yet, is it? Should I try to open a PR? (But be warned that I'd need some help.)

@doy
Copy link
Owner

doy commented Jun 20, 2024

i added this to the json output in 0942dde - if this works for you, i'd prefer this implementation, but let me know if there's some other functionality you'd like here.

@doy doy closed this Jun 20, 2024
@therealchfkch
Copy link

I think my needs are already satisfied with 869d364#diff-7d7d3a6ce5c2a3e8b39ce4f49b78a71365c8e06c0d9ddb78bc2dca68bfeb4a5bR150 in 1.10.0 but i could not test it yet. It looks good from looking at the code. Big thanks to all involved!

@fdw
Copy link
Author

fdw commented Jun 20, 2024

Yes, looks good to me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants