Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builder pattern for complex types #41

Closed
doyubkim opened this issue Dec 6, 2016 · 0 comments
Closed

Builder pattern for complex types #41

doyubkim opened this issue Dec 6, 2016 · 0 comments
Assignees
@doyubkim
Labels
api enhancement p1
Milestone
Release v1.0.0

Comments

@doyubkim
Copy link
Owner

doyubkim commented Dec 6, 2016

For instance, creating a face-centered grid or volume particle emitter takes significant number of parameters for their constructor. Adopting a builder pattern would be nice. Grid family does have simple builders, it is not really the builder for that purpose.
@doyubkim doyubkim self-assigned this Dec 6, 2016
@doyubkim doyubkim added the api label Dec 6, 2016
@doyubkim doyubkim added this to the Release v1.0.0 milestone Dec 12, 2016
@doyubkim doyubkim mentioned this issue Dec 13, 2016
Merged
doyubkim added a commit that referenced this issue Dec 13, 2016
@doyubkim
API (#42)
5b98b57 
This commit introduces new builder API (#41) to help the scene creation using C++ much easier. The builders are supported for most of the "actor" classes such as solvers, emitters, colliders, surfaces, and grids (#11). This change makes the example codes more readable as well (#28).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doyubkim doyubkim

Labels
api enhancement p1
Projects
None yet
Milestone
Release v1.0.0
Development

No branches or pull requests
1 participant
@doyubkim