[SDPA-1815] Process webform event using decode entities #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnykt
suggested changes
Feb 14, 2019
| @@ -123,38 +123,38 @@ function tide_event_webform_submission_presave($submission) { | |||
| $event_details_data = [ | |||
| 'type' => 'event_details', | |||
| 'field_paragraph_link' => [ | |||
| 'uri' => Html::escape($submission_data['website_url_for_booking']), | |||
| 'uri' => Html::decodeEntities(Html::escape($submission_data['website_url_for_booking'])), | |||
There was a problem hiding this comment.
@enzolutions Why do we need to escape/decode input data? Those utility functions from Html are for sanitising output.
There was a problem hiding this comment.
There was a problem hiding this comment.
I agree with you and that document, I already discuss that with @GROwen, so Guy is your call. we could remove those? and trust in Drupal Entity Saving validation for user Input?
|
This is the wrong approach to me. As discussed in the JIRA ticket we should not be sanitising input and will need to be careful on render (either from the frontend, but probably more correctly on JSONAPI output) that output is sanitised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://digital-engagement.atlassian.net/browse/SDPA-1815
Related PRs:
Changed
Screenshots