Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scipy Type Error Fix and Updated Requirements #7

Merged
merged 2 commits into from Sep 10, 2020

Conversation

andrewmoorman
Copy link

Fixed Issue #4 and updated requirements so latest Scipy is installed

Fixed the type error which results from the upgrade to Scipy > 1.4.1. This previously resulted from the way the sparse lil graph was constructed (using ndarray instead of list values) which requires lists as arguments.
Requirements now include >= Scipy v1.5.1
@hisplan hisplan self-requested a review September 10, 2020 13:05
@hisplan hisplan self-assigned this Sep 10, 2020
@hisplan hisplan added the bug label Sep 10, 2020
@hisplan hisplan merged commit 7aaf3c4 into dpeerlab:1.5.7 Sep 10, 2020
@hisplan
Copy link
Member

hisplan commented Sep 10, 2020

Next time, let's use this convention for the branch name e.g. release-1.5.7.

@andrewmoorman
Copy link
Author

Got it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants