Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate broken builds upon PR #65

Closed
nathanfletcher opened this issue Sep 23, 2021 · 4 comments · Fixed by #73
Closed

Investigate broken builds upon PR #65

nathanfletcher opened this issue Sep 23, 2021 · 4 comments · Fixed by #73
Assignees
@nathanfletcher

Comments

@nathanfletcher
Copy link
Collaborator

nathanfletcher commented Sep 23, 2021 •
edited
Loading

There seems to be a root issue that causes DPG Pull Requests to fail
Check out issues 700 and 703 of unicef/publicgoods-candidates
They broke but then were fixed manually by @nathanbaleeta
The goal is to find the root issue and see how the manual fixes by Nathan can be integrated
@nathanfletcher nathanfletcher self-assigned this Sep 23, 2021
@lacabra
Copy link
Collaborator

lacabra commented Sep 23, 2021 •
edited
Loading

Issue 700 failed for the same reason as 716, which has been addressed in #64.

Issue 703 remains outstanding

@lacabra
Copy link
Collaborator

lacabra commented Sep 23, 2021

Correction: after removing a null in 700 which was the cause of a CI failure, and new error appeared in the build, which matches that in 703.

@amreenp7
Copy link
Collaborator

@nathanfletcher to prioritize it this week (week of oct 18).

@amreenp7
Copy link
Collaborator

NF to look into this and provide an estimate re: timing

@nathanfletcher nathanfletcher mentioned this issue Oct 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanfletcher nathanfletcher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PATCH: JSON schema for doNoHarm and others dpgabot/submission-digitalpublicgoods
3 participants
@nathanfletcher @lacabra @amreenp7