Bug removing nulls from submission #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lacabra/submission-digitalpublicgoods/CQyU4dTvHFBcF62iVFmZuKZfCkH6 |
lacabra
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
Looks good to me. Thanks @nathanfletcher for the explanation, made all the difference to me in understanding the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #61
Just to double down on the
valuesobject being submitted, I'm reinitializing it after going through the recursive functionremoveNullsInArrays.I know
removeNullsInArraysmutates the array however I'm now returning the same object from the function and replacing it with its callervaluesonce again after testingremoveNullsInArrays.