Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Github actions to check Linting #21

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Conversation

DivyanshiSingh
Copy link
Contributor

Fixes: #18
Configured CI through Github actions to enforce Code style.
@lacabra please review and let me know the changes.

@vercel
Copy link

vercel bot commented Apr 25, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @lacabra on Vercel.

@lacabra first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lacabra/validation-digitalpublicgoods/kZFF7nLnStk34UkdkpFvFVJSGPvC
✅ Preview: https://validation-dig-git-fork-divyanshisingh-main-13b57f.vercel.app

Copy link
Collaborator

@lacabra lacabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you @DivyanshiSingh

@lacabra lacabra merged commit 6a9220e into dpgabot:main Apr 26, 2021
@lacabra lacabra mentioned this pull request Apr 26, 2021
@lacabra
Copy link
Collaborator

lacabra commented Apr 26, 2021

FYI @DivyanshiSingh: I didn't it mention in the original issue, but since this repo had Prettier configured as well, I also wanted to check for formatting in addition to the linter. Since it's easier for me to work directly on this repo than in a fork, I made those additional changes in #24 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub actions to enforce code style
2 participants