Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions to enforce Javascript code style #66

Closed
Tracked by #39
lacabra opened this issue Oct 15, 2021 · 8 comments · Fixed by #131
Closed
Tracked by #39

Add GitHub actions to enforce Javascript code style #66

lacabra opened this issue Oct 15, 2021 · 8 comments · Fixed by #131
Assignees
Labels
good first issue Good for newcomers

Comments

@lacabra
Copy link
Collaborator

lacabra commented Oct 15, 2021

After having implemented #65, configure the CI through GitHub Actions to enforce the code style upon committing files to the repo. Use dpgabot/validate-digitalpublicgoods#21 as a reference implementation

@lacabra lacabra added the good first issue Good for newcomers label Oct 15, 2021
@lacabra lacabra mentioned this issue Oct 15, 2021
12 tasks
@Lovelyfin00
Copy link

Hello @lacabra can I be assigned to this? I'm new to github so I don't know how long it will take for me to do this. But I would love to give it a try. Thank you!

@lacabra
Copy link
Collaborator Author

lacabra commented Oct 20, 2021

@Lovelyfin00 yes, I have assigned to you. Please note that #65 (there was a typo in the original description that has been corrected) needs to be completed first before this issue can be tackled. I also provided how a similar task was accomplished in a similar repository for your reference. You can start learning about GitHub Actions in the meantime

@Lovelyfin00
Copy link

Awesome. Thank you!

@Melodie97
Copy link
Contributor

Hi @lacabra @Lovelyfin00, can I also be assigned this project to collaborate with Lovelyn on this.

@nathanfletcher
Copy link
Contributor

Hi @Melodie97 I've added you as a co-collaborator. Can't wait to see what you both come up with.

@Melodie97
Copy link
Contributor

Thanks @nathanfletcher, pls do we still need to wait for issue #65, or has it been okay-ed ?

@Lovelyfin00
Copy link

Issue #65 hasn't been resolved yet

@nathanfletcher
Copy link
Contributor

#65 has been okay-ed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants