fix: security api (#1831)

* fix: security api * fix tests and add more tests * fix tests * fix tests * fix tests * fix tests * fix tests * fix tests * add type annotations to base * test mypy * fix lint * fix tests * fix mypy * fix mypy
dpgaspar · Apr 28, 2022 · 090ddb4 · 090ddb4
1 parent cb9c985
commit 090ddb4
Show file tree

Hide file tree

Showing 25 changed files with 722 additions and 422 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-18.04
     strategy:
       matrix:
-        python-version: [3.7]
+        python-version: [3.8]
     steps:
       - name: Checkout code
         uses: actions/checkout@v2

diff --git a/examples/crud_rest_api/config.py b/examples/crud_rest_api/config.py
@@ -2,6 +2,7 @@
 
 basedir = os.path.abspath(os.path.dirname(__file__))
 
+FAB_ADD_SECURITY_API = True
 CSRF_ENABLED = True
 SECRET_KEY = "\2\1thisismyscretkey\1\2\e\y\y\h"
 

diff --git a/flask_appbuilder/api/__init__.py b/flask_appbuilder/api/__init__.py
@@ -21,6 +21,7 @@
 from .convert import Model2SchemaConverter
 from .schemas import get_info_schema, get_item_schema, get_list_schema
 from .._compat import as_unicode
+from ..baseviews import AbstractViewApi
 from ..const import (
     API_ADD_COLUMNS_RES_KEY,
     API_ADD_COLUMNS_RIS_KEY,
@@ -203,7 +204,7 @@ def wrap(f):
     return wrap
 
 
-class BaseApi(object):
+class BaseApi(AbstractViewApi):
     """
         All apis inherit from this class.
         it's constructor will register your exposed urls on flask
@@ -213,8 +214,6 @@ class BaseApi(object):
         but provides a common base for all APIS.
     """
 
-    appbuilder = None
-    blueprint = None
     endpoint: Optional[str] = None
 
     version: Optional[str] = "v1"
@@ -436,6 +435,9 @@ def __init__(self) -> None:
 
             Initialization of extra args
         """
+        self.appbuilder = None
+        self.blueprint = None
+
         # Init OpenAPI
         self._response_key_func_mappings = dict()
         self.apispec_parameter_schemas = self.apispec_parameter_schemas or dict()
@@ -652,7 +654,7 @@ def get_uninit_inner_views(self):
         """
         return []
 
-    def get_init_inner_views(self, views):
+    def get_init_inner_views(self):
         """
             Sets initialized inner views
         """