fix: custom menu option (#1884)

flask_appbuilder/base.py

@@ -186,8 +186,8 @@ def init_app(self, app: Flask, session: SessionBase) -> None:
         # Setup Menu
         if _menu is not None:
             menu = dynamic_class_import(_menu)
-            if isinstance(menu, Menu):
-                self.menu = menu
+            if menu is not None and issubclass(menu, Menu):
+                self.menu = menu()
         else:
             self.menu = self.menu or Menu()
 

flask_appbuilder/tests/templates/custom_index.html

@@ -0,0 +1 @@
+This is a custom index view.

flask_appbuilder/tests/test_custom_indexview.py

@@ -0,0 +1,46 @@
+import logging
+import os
+
+from flask_appbuilder import IndexView, SQLA
+
+from .base import FABTestCase
+
+log = logging.getLogger(__name__)
+
+
+class CustomIndexView(IndexView):
+    index_template = "templates/custom_index.html"
+
+
+class FlaskTestCase(FABTestCase):
+    def setUp(self):
+        from flask import Flask
+        from flask_appbuilder import AppBuilder
+
+        self.app = Flask(__name__, template_folder=".")
+        self.basedir = os.path.abspath(os.path.dirname(__file__))
+        self.app.config.from_object("flask_appbuilder.tests.config_api")
+        self.app.config[
+            "FAB_INDEX_VIEW"
+        ] = "flask_appbuilder.tests.test_custom_indexview.CustomIndexView"
+
+        self.db = SQLA(self.app)
+        self.appbuilder = AppBuilder(self.app, self.db.session)
+
+    def tearDown(self):
+        self.appbuilder = None
+        self.app = None
+        self.db = None
+        log.debug("TEAR DOWN")
+
+    def test_custom_indexview(self):
+        """
+        Test custom index view.
+        """
+        uri = "/"
+        client = self.app.test_client()
+        rv = client.get(uri)
+
+        self.assertEqual(rv.status_code, 200)
+        data = rv.data.decode("utf-8")
+        self.assertIn("This is a custom index view.", data)