Merge pull request #631 from jgao54/fab-airflow

Add binary column support for sqlalchemy
dpgaspar · Oct 29, 2017 · 877f273 · 877f273
2 parents fd19e0e + 1f79b84
commit 877f273
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 0 deletions.
diff --git a/flask_appbuilder/forms.py b/flask_appbuilder/forms.py
@@ -39,6 +39,7 @@ class FieldConverter(object):
                         ('is_gridfs_file', MongoFileField, BS3FileUploadFieldWidget),
                         ('is_gridfs_image', MongoImageField, BS3ImageUploadFieldWidget),
                         ('is_text', TextAreaField, BS3TextAreaFieldWidget),
+                        ('is_binary', TextAreaField, BS3TextAreaFieldWidget),
                         ('is_string', StringField, BS3TextFieldWidget),
                         ('is_integer', IntegerField, BS3TextFieldWidget),
                         ('is_numeric', DecimalField, BS3TextFieldWidget),

diff --git a/flask_appbuilder/models/base.py b/flask_appbuilder/models/base.py
@@ -162,6 +162,9 @@ def is_string(self, col_name):
     def is_text(self, col_name):
         return False
 
+    def is_binary(self, col_name):
+        return False
+
     def is_integer(self, col_name):
         return False
 

diff --git a/flask_appbuilder/models/sqla/filters.py b/flask_appbuilder/models/sqla/filters.py
@@ -193,6 +193,14 @@ class SQLAFilterConverter(BaseFilterConverter):
                                      FilterNotEndsWith,
                                      FilterNotContains,
                                      FilterNotEqual]),
+                        ('is_binary', [FilterStartsWith,
+                                       FilterEndsWith,
+                                       FilterContains,
+                                       FilterEqual,
+                                       FilterNotStartsWith,
+                                       FilterNotEndsWith,
+                                       FilterNotContains,
+                                       FilterNotEqual]),
                         ('is_string', [FilterStartsWith,
                                        FilterEndsWith,
                                        FilterContains,

diff --git a/flask_appbuilder/models/sqla/interface.py b/flask_appbuilder/models/sqla/interface.py
@@ -168,6 +168,12 @@ def is_text(self, col_name):
         except:
             return False
 
+    def is_binary(self, col_name):
+        try:
+            return isinstance(self.list_columns[col_name].type, sa.types.LargeBinary)
+        except:
+            return False
+
     def is_integer(self, col_name):
         try:
             return isinstance(self.list_columns[col_name].type, sa.types.Integer)