Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Only update user.last_login on successful authentication (#1775)
* Only update user.last_login if they successfully authenticated * Update docstrings for update_user_auth_stat * Add tests for BaseSecurityManager.update_user_auth_stat Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com>
- Loading branch information
Showing
2 changed files
with
78 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
flask_appbuilder/tests/security/test_base_security_manager.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
import datetime | ||
import unittest | ||
from unittest.mock import MagicMock, patch | ||
|
||
from flask_appbuilder.security.manager import BaseSecurityManager | ||
|
||
|
||
@patch.object(BaseSecurityManager, "update_user") | ||
@patch.object(BaseSecurityManager, "__init__", return_value=None) | ||
class BaseSecurityManagerUpdateUserAuthStatTestCase(unittest.TestCase): | ||
def test_first_successful_auth(self, mock1, mock2): | ||
bsm = BaseSecurityManager() | ||
|
||
user_mock = MagicMock() | ||
user_mock.login_count = None | ||
user_mock.fail_login_count = None | ||
user_mock.last_login = None | ||
|
||
bsm.update_user_auth_stat(user_mock, success=True) | ||
|
||
self.assertEqual(user_mock.login_count, 1) | ||
self.assertEqual(user_mock.fail_login_count, 0) | ||
self.assertEqual(type(user_mock.last_login), datetime.datetime) | ||
self.assertTrue(bsm.update_user.called_once) | ||
|
||
def test_first_unsuccessful_auth(self, mock1, mock2): | ||
bsm = BaseSecurityManager() | ||
|
||
user_mock = MagicMock() | ||
user_mock.login_count = None | ||
user_mock.fail_login_count = None | ||
user_mock.last_login = None | ||
|
||
bsm.update_user_auth_stat(user_mock, success=False) | ||
|
||
self.assertEqual(user_mock.login_count, 0) | ||
self.assertEqual(user_mock.fail_login_count, 1) | ||
self.assertEqual(user_mock.last_login, None) | ||
self.assertTrue(bsm.update_user.called_once) | ||
|
||
def test_subsequent_successful_auth(self, mock1, mock2): | ||
bsm = BaseSecurityManager() | ||
|
||
user_mock = MagicMock() | ||
user_mock.login_count = 5 | ||
user_mock.fail_login_count = 9 | ||
user_mock.last_login = None | ||
|
||
bsm.update_user_auth_stat(user_mock, success=True) | ||
|
||
self.assertEqual(user_mock.login_count, 6) | ||
self.assertEqual(user_mock.fail_login_count, 0) | ||
self.assertEqual(type(user_mock.last_login), datetime.datetime) | ||
self.assertTrue(bsm.update_user.called_once) | ||
|
||
def test_subsequent_unsuccessful_auth(self, mock1, mock2): | ||
bsm = BaseSecurityManager() | ||
|
||
user_mock = MagicMock() | ||
user_mock.login_count = 5 | ||
user_mock.fail_login_count = 9 | ||
user_mock.last_login = None | ||
|
||
bsm.update_user_auth_stat(user_mock, success=False) | ||
|
||
self.assertEqual(user_mock.login_count, 5) | ||
self.assertEqual(user_mock.fail_login_count, 10) | ||
self.assertEqual(user_mock.last_login, None) | ||
self.assertTrue(bsm.update_user.called_once) |