Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allows to build views with multiple search widgets #1432

Closed

Conversation

ThomasP0815
Copy link
Contributor

@ThomasP0815 ThomasP0815 commented Jul 7, 2020

The changes in search.html are needed for proper mapping of the search criterias to the right form.

#1400

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #1432 (c420b53) into master (efc6944) will decrease coverage by 2.69%.
The diff coverage is n/a.

❗ Current head c420b53 differs from pull request most recent head 24e64eb. Consider uploading reports for the commit 24e64eb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1432      +/-   ##
==========================================
- Coverage   75.45%   72.75%   -2.70%     
==========================================
  Files          54       46       -8     
  Lines        7870     6354    -1516     
==========================================
- Hits         5938     4623    -1315     
+ Misses       1932     1731     -201     
Flag Coverage Δ
python 72.75% <ø> (-2.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/security/manager.py 57.83% <0.00%> (-14.26%) ⬇️
flask_appbuilder/models/sqla/filters.py 71.12% <0.00%> (-5.54%) ⬇️
flask_appbuilder/models/mixins.py 69.23% <0.00%> (-4.11%) ⬇️
flask_appbuilder/cli.py 51.06% <0.00%> (-3.62%) ⬇️
flask_appbuilder/security/sqla/manager.py 66.04% <0.00%> (-1.65%) ⬇️
flask_appbuilder/security/views.py 54.59% <0.00%> (-1.37%) ⬇️
flask_appbuilder/security/api.py 82.92% <0.00%> (-0.80%) ⬇️
flask_appbuilder/api/convert.py 91.47% <0.00%> (-0.67%) ⬇️
flask_appbuilder/babel/views.py 92.30% <0.00%> (-0.55%) ⬇️
flask_appbuilder/models/group.py 72.31% <0.00%> (-0.47%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c3989c...24e64eb. Read the comment docs.

@ThomasP0815 ThomasP0815 changed the title Fix, allows to build views with multiple search widgets fix: allows to build views with multiple search widgets Nov 30, 2020
@stale
Copy link

stale bot commented Mar 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Feel free to reopen it if it's still relevant to you. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants