Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [Deprecation] Use Markup instead of HTMLString #1729

Merged
merged 2 commits into from Nov 15, 2021
Merged

chore: [Deprecation] Use Markup instead of HTMLString #1729

merged 2 commits into from Nov 15, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 28, 2021

Description

Bump up requests to 2.26.0
Move from HTMLString to Markup due deprecation warnings

ADDITIONAL INFORMATION

  • Has associated issue:

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #1729 (8f7204c) into master (0747f7d) will increase coverage by 0.00%.
The diff coverage is 70.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1729   +/-   ##
=======================================
  Coverage   76.80%   76.80%           
=======================================
  Files          56       56           
  Lines        8113     8115    +2     
=======================================
+ Hits         6231     6233    +2     
  Misses       1882     1882           
Flag Coverage Δ
python 76.80% <70.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/fieldwidgets.py 63.15% <66.66%> (+0.32%) ⬆️
flask_appbuilder/upload.py 36.63% <75.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0747f7d...8f7204c. Read the comment docs.

@ghost ghost marked this pull request as ready for review October 28, 2021 14:01
@dpgaspar dpgaspar changed the title [Deprecation] Use Markup instead of HTMLString chore: [Deprecation] Use Markup instead of HTMLString Oct 28, 2021
@dpgaspar dpgaspar merged commit 071e66b into dpgaspar:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants