-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updated brackets in OAuth Authentication #1798
docs: updated brackets in OAuth Authentication #1798
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1798 +/- ##
==========================================
+ Coverage 77.08% 77.12% +0.04%
==========================================
Files 56 56
Lines 8226 8232 +6
==========================================
+ Hits 6341 6349 +8
+ Misses 1885 1883 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing, left a small comment
pretty sure thats aligned correctly but sorry if it still isn't hah
@dpgaspar the brackets are fixed and this can be merged now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, left a comment
Don't want to pester @dpgaspar but this is still open, was there anything else you wanted changed? I ended up just copying your block in the end |
Description
I changed what I believe to be incorrect brackets in the Security docs for the OAuth method
During a deployment of Apache Airflow I copied a chunk of code from the OAuth method in the Security documentation. When deploying I noticed errors related to the brackets and I believe that the bracket placement in the documentation is incorrect. I understand it's supposed to be something you copy what you need out of but if the whole chunk is copied it can be confusing why it doesnt work.
ADDITIONAL INFORMATION