Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: doc requirements #1820

Merged
merged 1 commit into from
Mar 21, 2022
Merged

fix: doc requirements #1820

merged 1 commit into from
Mar 21, 2022

Conversation

dpgaspar
Copy link
Owner

Description

Fix docs requirements

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #1820 (5e0f666) into master (a86835f) will increase coverage by 5.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1820      +/-   ##
==========================================
+ Coverage   71.48%   77.08%   +5.60%     
==========================================
  Files          56       56              
  Lines        8226     8226              
==========================================
+ Hits         5880     6341     +461     
+ Misses       2346     1885     -461     
Flag Coverage Δ
python 77.08% <ø> (+5.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/models/filters.py 89.11% <0.00%> (+0.68%) ⬆️
flask_appbuilder/models/base.py 74.03% <0.00%> (+1.10%) ⬆️
flask_appbuilder/upload.py 36.63% <0.00%> (+3.96%) ⬆️
flask_appbuilder/models/mongoengine/fields.py 69.44% <0.00%> (+27.77%) ⬆️
flask_appbuilder/security/mongoengine/manager.py 66.15% <0.00%> (+66.15%) ⬆️
flask_appbuilder/models/mongoengine/filters.py 68.57% <0.00%> (+68.57%) ⬆️
flask_appbuilder/models/mongoengine/interface.py 77.50% <0.00%> (+77.50%) ⬆️
flask_appbuilder/security/mongoengine/models.py 89.33% <0.00%> (+89.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a86835f...5e0f666. Read the comment docs.

@dpgaspar dpgaspar merged commit f6f66fc into master Mar 21, 2022
@dpgaspar dpgaspar deleted the fix/docs-requirements2 branch March 21, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant