-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add keycloak auth provider options #1832
feat: add keycloak auth provider options #1832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just the comment on the docs.
We are really needing tests for all these providers
…ivingston/Flask-AppBuilder into provider/new-oauth-provider-keycloak
I tested the Keycloak integration manually using the Bitnami Keycloak Docker image. I'm not sure how best to develop integration tests for Keycloak and the other providers for inclusion into the automated test suite. I'll give it some thought. |
That would be great, thank you once more |
@nilivingston conflict here, I merged another docs related PR. Can you fix it plz? |
I resolved the conflict by including both the keycloak and azure examples in |
Description
Adds auth provider options for Keycloak to
security/manager.py
. Update exampleoauth/config.py
to include "keycloak" and "keycloak_before_17" providers to demonstrate working configurations for Keycloak both before and after its version 17 API changes. Example config changes added todocs/security.rst
as well.Working out the necessary parameters for Keycloak integration was time consuming. Hopefully this configuration update and accompanying examples will make this process easier for other users.
ADDITIONAL INFORMATION