Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add keycloak auth provider options #1832

Merged
merged 9 commits into from
May 2, 2022
Merged

feat: add keycloak auth provider options #1832

merged 9 commits into from
May 2, 2022

Conversation

nilivingston
Copy link
Contributor

Description

Adds auth provider options for Keycloak to security/manager.py. Update example oauth/config.py to include "keycloak" and "keycloak_before_17" providers to demonstrate working configurations for Keycloak both before and after its version 17 API changes. Example config changes added to docs/security.rst as well.

Working out the necessary parameters for Keycloak integration was time consuming. Hopefully this configuration update and accompanying examples will make this process easier for other users.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the comment on the docs.

We are really needing tests for all these providers

docs/security.rst Outdated Show resolved Hide resolved
docs/security.rst Show resolved Hide resolved
@nilivingston
Copy link
Contributor Author

I tested the Keycloak integration manually using the Bitnami Keycloak Docker image. I'm not sure how best to develop integration tests for Keycloak and the other providers for inclusion into the automated test suite. I'll give it some thought.

@dpgaspar
Copy link
Owner

I tested the Keycloak integration manually using the Bitnami Keycloak Docker image. I'm not sure how best to develop integration tests for Keycloak and the other providers for inclusion into the automated test suite. I'll give it some thought.

That would be great, thank you once more

@dpgaspar
Copy link
Owner

@nilivingston conflict here, I merged another docs related PR. Can you fix it plz?

@nilivingston
Copy link
Contributor Author

@nilivingston conflict here, I merged another docs related PR. Can you fix it plz?

I resolved the conflict by including both the keycloak and azure examples in security.rst. Should be good to go.

@dpgaspar dpgaspar merged commit b210102 into dpgaspar:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants