Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove RemovedInMarshmallow4 warnings #2024

Merged
merged 5 commits into from
Jun 20, 2023
Merged

chore: remove RemovedInMarshmallow4 warnings #2024

merged 5 commits into from
Jun 20, 2023

Conversation

sebastianliebscher
Copy link
Contributor

Description

Since marshmallow 3.10 passing field metadata via keyword arguments is deprecated. Since marshmallow 3.13 the use of missing / default is deprecated. This PR makes changes accordingly.

@sebastianliebscher sebastianliebscher changed the title chore: RemovedInMarshmallow4 warnings chore: remove RemovedInMarshmallow4 warnings Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #2024 (f14a60f) into master (b2cec68) will decrease coverage by 5.31%.
The diff coverage is 100.00%.

❗ Current head f14a60f differs from pull request most recent head a45bf37. Consider uploading reports for the commit a45bf37 to get more accurate results

@@            Coverage Diff             @@
##           master    #2024      +/-   ##
==========================================
- Coverage   78.62%   73.32%   -5.31%     
==========================================
  Files          72       72              
  Lines        8698     8698              
==========================================
- Hits         6839     6378     -461     
- Misses       1859     2320     +461     
Flag Coverage Δ
python 73.32% <100.00%> (-5.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/security/sqla/apis/role/schema.py 100.00% <ø> (ø)
flask_appbuilder/security/sqla/apis/user/schema.py 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! thank you

@dpgaspar dpgaspar merged commit 9e8c540 into dpgaspar:master Jun 20, 2023
10 checks passed
@sebastianliebscher sebastianliebscher deleted the chore_marshmallow branch June 20, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants