Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update getting value usage. #2039

Merged
merged 1 commit into from
May 12, 2023

Conversation

VVildVVolf
Copy link
Contributor

@VVildVVolf VVildVVolf commented May 11, 2023

Description

Update getting value of select2 according to their recomendation: https://github.com/select2/select2/blob/4de1d236e602149a5c78d35899b49b3989b94107/src/js/select2/core.js#L536

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #2039 (95d0aeb) into master (0e08270) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2039      +/-   ##
==========================================
+ Coverage   78.46%   78.52%   +0.05%     
==========================================
  Files          72       72              
  Lines        8685     8698      +13     
==========================================
+ Hits         6815     6830      +15     
+ Misses       1870     1868       -2     
Flag Coverage Δ
python 78.52% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/models/sqla/interface.py 81.92% <ø> (ø)
flask_appbuilder/views.py 66.11% <ø> (ø)
flask_appbuilder/cli.py 61.18% <100.00%> (+2.25%) ⬆️

... and 1 file with indirect coverage changes

@VVildVVolf VVildVVolf changed the title Update getting value usage. fix: Update getting value usage. May 11, 2023
Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@dpgaspar dpgaspar merged commit 98e3808 into dpgaspar:master May 12, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants