Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select2-ajax-widget #2052

Merged
merged 3 commits into from
Jun 20, 2023
Merged

fix: select2-ajax-widget #2052

merged 3 commits into from
Jun 20, 2023

Conversation

nadircan
Copy link
Contributor

@nadircan nadircan commented Jun 2, 2023

Description

We discovered bug at releated_fields example. Select2SlaveAJAXWidget was not populated correctly to slave dropdown when master dropdown has changed. We discovered that related bug causes from e.val is undefined. I fixed the function loadSelectDataSlave, also my colleague (@ozanonurtek) fixed the example endpoint.

ADDITIONAL INFORMATION

  • New discovered bug

@ozanonurtek
Copy link
Contributor

@dpgaspar could you please review this change :)

Copy link
Contributor

@ozanonurtek ozanonurtek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit 9090d09 into dpgaspar:master Jun 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants