Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: marshmallow enum by value keep compatibility #2067

Merged
merged 6 commits into from
Jun 21, 2023
Merged

fix: marshmallow enum by value keep compatibility #2067

merged 6 commits into from
Jun 21, 2023

Conversation

dpgaspar
Copy link
Owner

@dpgaspar dpgaspar commented Jun 21, 2023 •
edited

Description

Using default marshmallow Enum by value option is a breaking change for FAB. This PR changes the Enum by_value default to True.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@dpgaspar dpgaspar merged commit a539e00 into master Jun 21, 2023
11 checks passed
@dpgaspar dpgaspar deleted the fix/enum-by-val-key-option branch June 21, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dpgaspar