Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: old API api column edit #2134

Merged
merged 3 commits into from
Oct 23, 2023
Merged

fix: old API api column edit #2134

merged 3 commits into from
Oct 23, 2023

Conversation

dpgaspar
Copy link
Owner

Description

Fixes: #2104

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #2134 (0bbb03b) into master (0a5aec9) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #2134   +/-   ##
=======================================
  Coverage   79.31%   79.31%           
=======================================
  Files          72       72           
  Lines        8970     8970           
=======================================
  Hits         7115     7115           
  Misses       1855     1855           
Flag Coverage Δ
python 79.31% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flask_appbuilder/views.py 66.80% <0.00%> (ø)

@dpgaspar dpgaspar merged commit 8203783 into master Oct 23, 2023
13 of 14 checks passed
@dpgaspar dpgaspar deleted the fix/old-api-edit-col branch October 23, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing .get(col_name)
1 participant