Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add support for Python 3.10, 3.11, 3.12 and drop 3.7 #2147

Merged
merged 24 commits into from
Oct 23, 2023

Conversation

Dosenpfand
Copy link
Contributor

@Dosenpfand Dosenpfand commented Oct 22, 2023

Description

Add support for actively maintained Python versions and drop support for unmaintained versions.
Among many advantages, this makes it possible to update dependencies to recent versions, that do not have security vulnerabilities, see #2136 .

Includes

  1. Add Python 3.10, 3.11, and 3.12 builds to and remove 3.7 from ci.yml.
  2. Switch from nosetests to nose2 (a maintained version that supports recent Python versions) and adapt tests and invocation calls accordingly.
  3. Switch to the most recent black version and format everything with it (needed to work with recent click versions.)
  4. In setup.py pin flask and werkzeug to lower versions for compatibility.
  5. Update requirements.txt via pip-compile.
  6. Bump pyodbc and python-ldap versions in requirements-extra.txt.
  7. Update the mongo dependencies in requirements-mongodb.txt to the most recent versions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@Dosenpfand Dosenpfand mentioned this pull request Oct 22, 2023
6 tasks
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #2147 (16ac0c2) into master (3cfe13f) will increase coverage by 0.76%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2147      +/-   ##
==========================================
+ Coverage   78.55%   79.31%   +0.76%     
==========================================
  Files          72       72              
  Lines        8695     8970     +275     
==========================================
+ Hits         6830     7115     +285     
+ Misses       1865     1855      -10     
Flag Coverage Δ
python 79.31% <33.33%> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flask_appbuilder/_compat.py 70.58% <ø> (ø)
flask_appbuilder/actions.py 93.75% <ø> (ø)
flask_appbuilder/api/manager.py 92.45% <ø> (ø)
flask_appbuilder/babel/manager.py 95.45% <ø> (ø)
flask_appbuilder/basemanager.py 100.00% <ø> (ø)
flask_appbuilder/baseviews.py 90.89% <ø> (+1.17%) ⬆️
flask_appbuilder/charts/jsontools.py 100.00% <ø> (ø)
flask_appbuilder/charts/views.py 93.87% <ø> (+0.69%) ⬆️
flask_appbuilder/filemanager.py 25.16% <ø> (ø)
flask_appbuilder/filters.py 90.99% <ø> (ø)
... and 24 more

... and 9 files with indirect coverage changes

Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!!

@@ -66,14 +66,15 @@ def desc():
"SQLAlchemy<1.5",
"sqlalchemy-utils>=0.32.21, <1",
"WTForms<4",
"werkzeug<3", # Otherwise breaks Flask-Login 0.6.2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you for adding these "stops" and comments

@dpgaspar dpgaspar merged commit eed6d86 into dpgaspar:master Oct 23, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants