Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: openID provider validation flow #2186

Merged
merged 7 commits into from
Feb 6, 2024
Merged

fix: openID provider validation flow #2186

merged 7 commits into from
Feb 6, 2024

Conversation

dpgaspar
Copy link
Owner

@dpgaspar dpgaspar commented Feb 6, 2024

Description

On OpenID use the provider name instead of the URL, fetch the required URL from the app config

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59db85d) 79.31% compared to head (ccb1f73) 79.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2186      +/-   ##
==========================================
+ Coverage   79.31%   79.45%   +0.14%     
==========================================
  Files          72       72              
  Lines        8974     8982       +8     
==========================================
+ Hits         7118     7137      +19     
+ Misses       1856     1845      -11     
Flag Coverage Δ
python 79.45% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpgaspar dpgaspar merged commit 6336456 into master Feb 6, 2024
14 checks passed
@dpgaspar dpgaspar deleted the fix/openid-login branch February 6, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant