-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"-std=c11" is required #3
Comments
The "-std=gnu11" flag is now automatically added if necessary: ab268e5 Newer versions of gcc and clang have c11 support enabled by default, but apparently gcc pre-5 uses "-std=gnu89" by default. |
entn-at
pushed a commit
to entn-at/libfvad
that referenced
this issue
Aug 3, 2018
…n (patchset dpirch#2 id:160001 of https://codereview.chromium.org/3002033002/ ) Reason for revert: Fixes has landed. Original issue's description: > Revert of Fix the video buffer size should take rtt into consideration (patchset dpirch#3 id:40001 of https://codereview.chromium.org/2980413002/ ) > > Reason for revert: > We are not certain this is the behavior we want. > > Original issue's description: > > Fix the video buffer size should take rtt into consideration > > > > BUG=webrtc:8010 > > > > Review-Url: https://codereview.webrtc.org/2980413002 > > Cr-Commit-Position: refs/heads/master@{#19285} > > Committed: https://chromium.googlesource.com/external/webrtc/+/f1e08d0b5848d32fd31c5b6e4e570115c32b7ce5 > > TBR=sprang@webrtc.org,gustavogb@gmail.com > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:8010 > > Review-Url: https://codereview.webrtc.org/3002033002 > Cr-Commit-Position: refs/heads/master@{#19442} > Committed: https://chromium.googlesource.com/external/webrtc/+/bdbc8895f3a630a4fe28d4661d8e71877ecaf14d TBR=sprang@webrtc.org,gustavogb@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:8010 Review-Url: https://codereview.webrtc.org/3016633002 Cr-Commit-Position: refs/heads/master@{#19944}
entn-at
pushed a commit
to entn-at/libfvad
that referenced
this issue
Aug 3, 2018
…n (patchset dpirch#3 id:40001 of https://codereview.chromium.org/2980413002/ ) Reason for revert: We are not certain this is the behavior we want. Original issue's description: > Fix the video buffer size should take rtt into consideration > > BUG=webrtc:8010 > > Review-Url: https://codereview.webrtc.org/2980413002 > Cr-Commit-Position: refs/heads/master@{#19285} > Committed: https://chromium.googlesource.com/external/webrtc/+/f1e08d0b5848d32fd31c5b6e4e570115c32b7ce5 TBR=sprang@webrtc.org,gustavogb@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:8010 Review-Url: https://codereview.webrtc.org/3002033002 Cr-Commit-Position: refs/heads/master@{#19442}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While README.md states:
It is actually required to use "-std=c11" for the compiled library to work, otherwise problems will arise either when compiling or importing. Maybe the flag should be added to the makefiles.
Tested with GCC 4.8.5: if no "-std" flags are specified, compilation fails with
and if "-std=c99" is specified, if the warnings are turned on, many warnings can be seen:
using the compiled library will raise an error similar to "undefined symbol: static_assert".
The text was updated successfully, but these errors were encountered: