Alter test skips: python-lz4 works on python26, but not pypy

dpkp · Mar 14, 2017 · cf4ac27 · cf4ac27
1 parent 9ba21b8
commit cf4ac27
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/test/test_buffer.py b/test/test_buffer.py
@@ -2,6 +2,7 @@
 from __future__ import absolute_import
 
 import io
+import platform
 
 import pytest
 
@@ -34,7 +35,8 @@ def test_buffer_close():
 @pytest.mark.parametrize('compression', [
     'gzip',
     'snappy',
-    pytest.mark.skipif("sys.version_info < (2,7)")('lz4'), # lz4tools does not work on py26
+    pytest.mark.skipif(platform.python_implementation() == 'PyPy',
+                       reason='lz4 does not work on pypy')('lz4'),
 ])
 def test_compressed_buffer_close(compression):
     records = MessageSetBuffer(io.BytesIO(), 100000, compression_type=compression)

diff --git a/test/test_producer.py b/test/test_producer.py
@@ -31,8 +31,8 @@ def test_end_to_end(kafka_broker, compression):
         # LZ4 requires 0.8.2
         if version() < (0, 8, 2):
             return
-        # LZ4 python libs don't work on python2.6
-        elif sys.version_info < (2, 7):
+        # python-lz4 doesn't work on pypy yet
+        elif platform.python_implementation() == 'PyPy':
             return
 
     connect_str = 'localhost:' + str(kafka_broker.port)