Remove raw traceback #1221
Merged
Remove raw traceback #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be noted that stack_info was added in Python 3.2, but logging accepts an arbitrary **kwargs input, so I think in older versions it will just not print the stack information, but still print the error message. *Apparently pypy throws an exception instead of doing nothing - I'm not sure if that's intended. |
Pypy (and maybe other implementations besides CPython) doesn't ignore extra keyword arguments to log.warning, and raises an exception instead. The argument stack_info was added in 3.2, so not using it in older versions shouldn't affect the other implementations.
|
Thanks! |
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1220