Threaded producer #153
Closed
Threaded producer #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reinit was also used to reconnect on connection errors. |
|
@snaury This doesn't merge cleanly currently. Could you try to fix the conflicts so it can be ready for merge? |
|
Thanks snaury! vshlapakov got this to merge in PR 330. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned out to be a little more involved than I anticipated, since KafkaConnection had a major bug with copy() and threads (due to subclassing threading.local). As a side effect reinit() is not mandatory anymore, client will automatically reconnect when it is used for the first time after a copy().