Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the optional compression libs to extras_require #2123

Merged
merged 3 commits into from Nov 15, 2020
Merged

Add the optional compression libs to extras_require #2123

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5f6a47
Add lz4 and snappy to extras_require
jeffwidman Sep 17, 2020
1b9a779
add python-zstandard
jeffwidman Sep 17, 2020
fe404d6
rename to `"zstd"`
jeffwidman Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion setup.py
View file
Open in desktop
Expand Up @@ -35,7 +35,12 @@ def run(cls):
version=__version__,

tests_require=test_require,
extras_require={"crc32c": ["crc32c"]},
extras_require={
"crc32c": ["crc32c"],
"lz4": ["lz4"],
"snappy": ["python-snappy"],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if we should take the "snappy" namespace or use "python-snappy" so as to disambiguate between different implementations if we later have support for a pure-python vs c-based lib... this applies to the "zstd" entry as well...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpkp @tvoinarovskyi any opinion?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dropping the python- prefix is fine here.

"zstd": ["python-zstandard"],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually correct? It looks like the PyPI package is just zstandard. When testing installing only this package locally, I get an error:

$ pip install python-zstandard
ERROR: Could not find a version that satisfies the requirement python-zstandard (from versions: none)
ERROR: No matching distribution found for python-zstandard

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing the same error after cloning repository and trying to install with the extra locally.

$ pip install -e .[zstd]
Obtaining file:///Users/anton/projects/kafka-python
  Preparing metadata (setup.py) ... done
ERROR: Could not find a version that satisfies the requirement python-zstandard; extra == "zstd" (from kafka-python[zstd]) (from versions: none)
ERROR: No matching distribution found for python-zstandard; extra == "zstd"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd be better off opening a new issue, as comments on old PR's tend to get lost.

},
cmdclass={"test": Tox},
packages=find_packages(exclude=['test']),
author="Dana Powers",
Expand Down