Correct message keys for async batching mode #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a reasonable approach. Another possibility would be to use a namedtuple. Will take a closer look in the next few days. Would like to get this issue fixed before next release! |
|
@dpkp Indeed, it's an important fix, I can confirm that enabled Kafka log compaction will delete all messages with same keys at the topic, and it's an irreversible loss of data. I can change it with |
dpkp
added a commit
that referenced
this pull request
Mar 29, 2015
Correct message keys for async batching mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There're some possible changes relative to #325.
As create_message_set() method is called only from base Producer class and from _send_upstream(), I've changed it a little bit, so messages sent as a list of (msg, key) tuples. I've added some basic tests also.
Take a look please, probably it can be improved.
(This PR is squashed to the other branch #326.)