Make external API consistently support python3 strings for topic. #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -258,15 +258,19 @@ def reset_all_metadata(self): | |||
| self.topic_partitions.clear() | |||
|
|
|||
| def has_metadata_for_topic(self, topic): | |||
There was a problem hiding this comment.
why not simply set topic = kafka_bytestring(topic) ?
There was a problem hiding this comment.
I did it this way as a premature optimization because I saw has_metadata_for_topic and get_partition_ids_for_topic were on the callpath of send_messages which is probably the most used method and always calls these metadata methods with a byte string. But on closer inspection, it should only call them once on initialization, so its probably clearer to use a consistent pattern.
|
thanks -- test error looks like a travis-ci failure. do you mind squashing your second commit or git commit --amend ? |
dpkp
added a commit
that referenced
this pull request
Apr 4, 2015
Make external API consistently support python3 strings for topic.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that python3 string topics were supported in SimpleProducer.send_messages but not elsewhere in the API. This change makes python3 string topics supported throughout the public API.
This required changes in some testing code to ensure that bytes were used when building internal structs for return and sending to kafka service.