try to fix uncaught FailedPayloadsError in consumer #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And this fix not solve the second problem about NotLeaderForPartitionError after the failed broker recover |
| @@ -341,6 +341,8 @@ def _fetch(self): | |||
| for resp in responses: | |||
|
|
|||
| try: | |||
| if isinstance(resp, Exception): | |||
| raise resp | |||
There was a problem hiding this comment.
this check can probably move into the kafka.utils.check_error function
|
thanks for the PR! I added a few comments, and also would love if you could take a stab at adding a test for this. |
reAsOn2010
force-pushed
the
fix-uncaught-FailedPayloadsError
branch
from
cb6d561
to
945fc04
Compare
dpkp
added a commit
that referenced
this pull request
Jun 8, 2015
try to fix uncaught FailedPayloadsError in consumer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
about #386. It‘s a not that elegant fix, but works...