ConsumerCoordinator cleanups and test coverage #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 10, 2016 08:57
- default assignors to RoundRobinPartitionAssignor - check offsets types in commit_offsets_* methods - succeed future in _send_offset_commit_request when no offsets - raise exception if no subscribed topics in group_protocols() - fix _subscription typo in metadata listener callbacks - short circuit if no partitions passed to fetch_committed_offsets - line-wrap comments - return future from commit_offsets_async - return future value from commit_offsets_sync - fix self._failed_request callback partial args - comment out metrics class for now
dpkp
force-pushed
the
coordinator_tests
branch
2 times, most recently
from
048a041
to
34356cc
Compare
dpkp
force-pushed
the
coordinator_tests
branch
from
34356cc
to
240f702
Compare
dpkp
added a commit
that referenced
this pull request
Jan 10, 2016
ConsumerCoordinator cleanups and test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.