Add protocol support for ApiVersionRequest #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -225,7 +225,7 @@ def __init__(self, *topics, **configs): | |||
| # Check Broker Version if not set explicitly | |||
| if self.config['api_version'] == 'auto': | |||
| self.config['api_version'] = self._client.check_version() | |||
| assert self.config['api_version'] in ('0.9', '0.8.2', '0.8.1', '0.8.0'), 'Unrecognized api version' | |||
| assert self.config['api_version'] in ('0.10', '0.9', '0.8.2', '0.8.1', '0.8.0'), 'Unrecognized api version' | |||
There was a problem hiding this comment.
This should probably be refactored. A user should not ever need to pass in api_version='0.10' since that broker supports ApiVersionRequest.
There was a problem hiding this comment.
But the user still could set api_version='0.10' (or higher in the future) right?
|
Woot! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the api to identify 0.10 brokers in check_version.
Leaving deeper support for ApiVersion response (min / max versions) for a separate task.