Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search result should also include Node-name #461

Closed
GoogleCodeExporter opened this issue Aug 23, 2015 · 9 comments
Closed

Search result should also include Node-name #461

GoogleCodeExporter opened this issue Aug 23, 2015 · 9 comments

Comments

@GoogleCodeExporter
Copy link

I have in my file the word 'Amazon' assigned to a node. Nowhere else I use this 
word. 

When I search for amazon nothing is found.

I would expect that the node 'Amazon' is listed as well. 

Since I have so many nodes, its hard to find sometimes, especially when the 
node-structure is historical grown and not really well sorted.

Original issue reported on code.google.com by atha4y...@gmail.com on 5 Feb 2013 at 8:36

@GoogleCodeExporter
Copy link
Author

Hi atha4y

Have you tried to search via F9 resource panel Find?
Tick "search node names".
At least for me this works exactly as it should.

Original comment by stati...@gmx.net on 5 Feb 2013 at 7:44

@GoogleCodeExporter
Copy link
Author

Hi,

see attached screenshot. Yeah, the search was done via F9, search panel.

Original comment by atha4y...@gmail.com on 10 Feb 2013 at 8:30

Attachments:

@GoogleCodeExporter
Copy link
Author

Hi atha4y,

- Do you find no node name at all or just no "Amazon"?
- Does this also happen when you click somewhere in the node tree and press 
CTRL+SHIFT+F to start a "Find tree node" search?

Original comment by stati...@gmx.net on 11 Feb 2013 at 9:13

@GoogleCodeExporter
Copy link
Author

Hi,

I checked little bit further and a brief summary:

- I find nodes where the search text is at least included in the description 
(right panel)
- IFFF the search text is included in the node ONLY, then it is not found, no 
matter, if the node description consists of one or two words. They are simply 
not taken into account.
- Searching with CTRL+SHIFT+F improves the result, but only very little. If I 
have selected a node prior the search node (e.g. INTERNET), then the node is 
found. But when I select a node *after* the search result (e.g. Test-Node1, 
which is after Amazon), then the node is not found. So, I would conclude there 
is no wrap search included for the "Find tree node" search.

As a total conclusion I would say, the names of the node are not taken into 
account. Since you have found a node, I am curious, if the search text is as 
well included in the detailed description panel (right panel). 

Or might it be related with the type of encryption? or???


Original comment by atha4y...@gmail.com on 14 Feb 2013 at 6:51

@GoogleCodeExporter
Copy link
Author

[deleted comment]

@GoogleCodeExporter
Copy link
Author

I don't think that encryption is linked with this issue. Nearly all my keynote 
files are encrypted but I never found that this was the base of any problem I 
had.

The CTRL+SHIFT+F NodenameSearch works only one way forward and not in a 360 
loop.
So what you described is KeyNote's normal behavour.
I normally start this search type with POS1 from the top of the tree, then it 
works out as it should.
To find repeated identical node names an F3 continue search would be handy. For 
the moment you have to type CTRL+F again and again. 

As for your initial F9 search problem: 
can you verify that in search type section "exact phrase" is ticked and not 
"all the words" or "any of the words"?
With the later two I also get no search result for node names but just for 
content. 
With "exact phrase" and "search node names" ticked I get everything, node names 
and content.
Don't know why but as long as "exact phrase" works I don't care too much. 

Original comment by stati...@gmx.net on 17 Feb 2013 at 12:35

@GoogleCodeExporter
Copy link
Author

Thx for the response. I checked now as well all options and its like you say:

"exact phrase" enables "Search node names", while the other two option disable 
this option. BUT leave it checked. Which would mean, in my perception: I cannot 
change this selection and therefore the option is taken into account.

So, its more or less a perception problem. Yeah, it works, but :|

IFFFF I would suggest a fix, then I would vote for GUI-change, namely to remove 
the option  "Search node names", and change "exact phrase" into "exact phrase 
and search in node names". But, I know there is this backward-compatiblity....

ORRR another approach would be: When disabled, then deselect "exact phrase" as 
well. And enabled again, then leave it deselected... At least the GUI does what 
it says.

With, or without the minor GUI-changes, I think you could close this Issue. Thx 
for support.

Original comment by atha4y...@gmail.com on 18 Feb 2013 at 6:31

@dpradov
Copy link
Owner

dpradov commented Nov 11, 2015

To find repeated identical node names an F3 continue search would be handy. For the moment you have to type CTRL+F again and again.

Could be a minor enhancement (-> ToDOs)

can you verify that in search type section "exact phrase" is ticked and not "all the words" or "any of the words"? With the later two I also get no search result for node names but just for content. With "exact phrase" and "search node names" ticked I get everything, node names and content.

I don't remember the origin of this limitation. It was present on KeyNote 1.6.5 as well. To take a look (-> ToDOs)

Stati..., thanks for you continuous help and support to others 👍

@dpradov
Copy link
Owner

dpradov commented Nov 11, 2015

Related to #156

dpradov added a commit that referenced this issue Dec 1, 2015
Now, Ctrl+F and F3 (or actual hotkeys) will call to 'Find...'/'Find Node...' or 'Find Next'/'Find Next Node' depending on the tree panel having or not the focus.
Also, the command 'Find Next Node' will search all the notes and/or all the hidden nodes depending of the options selected in the find tab of the Resource panel ("Search all notes" and "Search hidden nodes")

Closes issues #286 and relates to a minor enhancement indicated in #461 and #156

Signed-off-by: Daniel Prado Velasco <dpradov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants