Scroll on note when switching notes #520
Comments
|
The problem was originated in changes from #57 Now, apart from only invoking from PagesChange to EditorToDataStream when is really necessary (when there have been changes in a mirrored node of that one we are now selecting), changes have been made to optimize, reducing, the movements between the Editor and the Stream of the nodes/notes, only copying from Editor to Stream of node/note when there are modifications in the Editor. The last modification does also have an useful and important consequence: if we don't modify a node or note, it will not be modified when the file is saved to disk. So, if there is any compatibility problems between the RTF content of the node/note and the RichEdit version, perhaps will not be correctly shown, but will be maintained unchanged in disk. |
With the change made in #520, in EditorToDataStream (TTabNote and TTreeNote), to only copy from Editor to Stream of node/note when there are modifications in the Editor, its necessary that the stream of the node/note is always available. But in TTabNote.DataStreamToEditor, after copying to the Editor the data stream was cleared. I think that it was a risky optimization, based on the fact that EditorToDataStream was always called at the end. Without this correction, the changes in #520 would cause the RTF notes to be saved empty! Signed-off-by: Daniel Prado Velasco <dpradov@users.noreply.github.com>
It is related to a problem arised with changes in #520 and partially corrected with commit 4b969a2. The (big) problem affects only to Standard Rich text notes (non multi-level tree): they are being saved empty after the second time the file is saved, if its content have been not modified. Signed-off-by: Daniel Prado Velasco <dpradov@users.noreply.github.com>
From #208:
The text was updated successfully, but these errors were encountered: