Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorites in Resource Panel need to be refreshed in 1.8.xx #631

Closed
hcwxyz opened this issue Dec 29, 2023 · 5 comments
Closed

Favorites in Resource Panel need to be refreshed in 1.8.xx #631

hcwxyz opened this issue Dec 29, 2023 · 5 comments

Comments

@hcwxyz
Copy link

hcwxyz commented Dec 29, 2023

Starting with v. 1.8.xxx, favorites (for me, 5 KN files) no longer appear automatically but require right-clicking the panel and selecting the "refresh list" each time any KN file is opened. This feature worked flawlessly in earlier versions.

@dpradov
Copy link
Owner

dpradov commented Jan 12, 2024

Hello @hcwxyz
I am testing what you point out with the latest version, 1.8.3 and I can't find anything abnormal. In my case it recharges automatically without any problem.

Could you try renaming your .fvr file and creating another one from the new version adding some files, in case there was something strange in that file that was causing problems with the new versions? Are those .KNT files that you indicate added as external elements or as locations?

@hcwxyz
Copy link
Author

hcwxyz commented Jan 13, 2024 via email

@dpradov
Copy link
Owner

dpradov commented Jan 13, 2024

In your tests, do you have the resources panel closed or open when opening KeyNote?
I understand that your .fvr file is located in the "\Profiles\Default" folder. Is that correct?

Can you do any other tests?

  1. Rename your Macros, Plugins and Templates folders, to rule out loading any of them being the cause of the problem.
    Open the file and check if the problem persists.

  2. Rename your configuration file, keynote.ini, to open the file with default values, in case any option could be affecting it.

And finally, can you check what system codepage do you have? (See the following issue to see what I mean: #618 )

@hcwxyz
Copy link
Author

hcwxyz commented Jan 13, 2024 via email

@dpradov
Copy link
Owner

dpradov commented Jan 16, 2024

Hi @hcwxyz
At the moment I can't think of what could be happening. I'll try to think about it another time

Regards
Daniel

dpradov added a commit that referenced this issue Mar 23, 2024
…assions

I was finally able to reproduce this issue once, enough to identify and fix it

With the help of the 3rdParty TFormStorage control (RxPlacement.pas) KeyNote recovers the position and state of the windows (saved in the keynote.mru file). This occurs when the main KeyNote window is displayed, before it is activated.
From what I had been observing, it seemed that this process ( =>TFormPlacement.RestorePlacement) ended before continuing to process other messages. But it didn't have to be that way.
Sometimes (in my case very rare occasions) the Activate message (on the main form) is received before that process has finished. In this case, the active tab in the resources panel may not have been restored yet. But nevertheless, it is in FormActivate where the initial loading of the resource panel is carried out (on its active tab)
Fortunately the TFormStorage control offers an event that reports the completion of the restore placement process.

(In my case it is something very, very unusual. Few minutes after adding the code that clearly corrected the problem, the favorites panel began showing correctly on the startup, even commenting the new code)

Refs:
 Favorites in Resource Panel need to be refreshed in 1.8.xx #631
 "Resource Panel>Favorites, not autocomplete" #655
@dpradov dpradov closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants