Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The upgrade path of dprint-plugin-prettier from 0.26.6 to 0.27.0 requires both dprint 0.39.1 and 0.40.0 #56

Closed
kachick opened this issue Jul 31, 2023 · 3 comments
Closed

The upgrade path of dprint-plugin-prettier from 0.26.6 to 0.27.0 requires both dprint 0.39.1 and 0.40.0 #56

kachick opened this issue Jul 31, 2023 · 3 comments

Comments

@kachick
Copy link
Sponsor

kachick commented Jul 31, 2023

In dprint 0.39.1 and config with prettier-0.26.6, dprint config update updates the config, but dprint check and dprint fmt fails after updated

[dprint-plugin-prettier]
Shutting down due to error: failed to fill whole buffer
Error resolving plugin https://plugins.dprint.dev/prettier-0.27.0.json: Failed plugin schema verification. This may indicate you are using an old version of the dprint CLI or plugin and should upgrade.: The plugin schema version was 5, but expected 4.

In dprint 0.40.0 and config with prettier-0.26.6, dprint config update failed with handling old plugins messages

[dprint-plugin-prettier]
Shutting down due to error: Error reading message from stdin.
Shutting down due to error: Error reading message from stdin.
Error resolving plugin https://plugins.dprint.dev/prettier-0.26.6.json: Failed plugin schema verification. This may indicate you are using an old version of the dprint CLI or plugin and should upgrade.: The plugin schema version was 4, but expected 5.

In this case, I should first update the config with dprint 0.39.1 and then immediately upgrade dprint to 0.40.0. Is this an intended migration flow?
kachick added a commit to mobu-of-the-world/mobu that referenced this issue Jul 31, 2023
@kachick
Manually bump prettier plugin
8e61f3e 
dprint/dprint-plugin-prettier#56
renovate bot pushed a commit to mobu-of-the-world/mobu that referenced this issue Jul 31, 2023
@kachick @renovate
Manually bump prettier plugin
bca96f7 
dprint/dprint-plugin-prettier#56
kachick added a commit to kachick/action-update-dprint-plugins that referenced this issue Jul 31, 2023
@kachick
Add notes
512c3f0 
dprint/dprint-plugin-prettier#56
@kachick
Copy link
Sponsor Author

kachick commented Jul 31, 2023

I'll replace manually for these versions. 🙇‍♂️

@kachick kachick closed this as completed Jul 31, 2023
@dsherret
Copy link
Member

dsherret commented Jul 31, 2023 •
edited
Loading

Yes, sorry you need to manually update the urls in the configuration file as it was too much work to make a smooth upgrade path (and dprint is still 0.x).

See here for details: dprint/dprint#726 (comment)

kachick added a commit to mise-plugins/asdf-cargo-make that referenced this issue Jul 31, 2023
@kachick
Manually edit versions for both dprint and prettier plugin
db3f084 
dprint/dprint-plugin-prettier#56
@kachick
Copy link
Sponsor Author

kachick commented Jul 31, 2023

Sure! Thank you for sharing it with me, dprint project helps me a lot 🙏

This was referenced Jul 31, 2023
Closed
Closed
Closed
kachick added a commit to kachick/anylang-template that referenced this issue Aug 5, 2023
@kachick
Bump rtx version manually
7a3cc2d 
```bash
rtx exec dprint@0.39.1 -- dprint config update --yes
rtx exec dprint@0.40.0 -- dprint check
```

dprint/dprint-plugin-prettier#56
kachick added a commit to kachick/dotfiles that referenced this issue Aug 6, 2023
@kachick
Remove dprint config update from updater
6d5cdba 
The feature does not keep working plugins

See dprint/dprint-plugin-prettier#56
kachick added a commit to kachick/nixpkgs-url that referenced this issue Aug 6, 2023
@kachick
Bump dprint plugins version with rtx
781ac3d 
```bash
rtx exec dprint@0.39.1 -- dprint config update --yes
rtx exec dprint@0.40.0 -- dprint check
```

dprint/dprint-plugin-prettier#56
kachick added a commit to mobu-of-the-world/emobu that referenced this issue Aug 6, 2023
@kachick
Bump dprint plugins version with rtx
6a8e4d2 
```bash
rtx exec dprint@0.39.1 -- dprint config update --yes
rtx exec dprint@0.40.0 -- dprint check
```

dprint/dprint-plugin-prettier#56
kachick added a commit to kachick/dotfiles that referenced this issue Aug 6, 2023
@kachick
Bump dprint plugins version with rtx
837f1a2 
```bash
rtx exec dprint@0.39.1 -- dprint config update --yes
rtx exec dprint@0.40.0 -- dprint check
```

dprint/dprint-plugin-prettier#56
kachick added a commit to kachick/renovate-config-dprint that referenced this issue Aug 8, 2023
@kachick
Pin dprint version to fix broken CI
1ce2871 
dprint/dprint-plugin-prettier#56
https://github.com/kachick/renovate-config-dprint/actions/runs/5793095750/job/15700335373
kachick added a commit to kachick/renovate-config-dprint that referenced this issue Aug 8, 2023
@kachick
Bump dprint.json with old dprint
308e7a3 
`rtx exec dprint@0.39.1 -- dprint config update --yes && rtx exec dprint@0.40.0 -- dprint check`

dprint/dprint-plugin-prettier#56
kachick added a commit to kachick/elm-dependency-submission that referenced this issue Oct 5, 2023
@kachick
Bump dprint.json with old dprint
6d880bd 
`rtx exec dprint@0.39.1 -- dprint config update --yes && rtx exec dprint@0.40.2 -- dprint fmt`

dprint/dprint-plugin-prettier#56

And removed outdated includes specifier
kachick added a commit to kachick/elm-dependency-submission that referenced this issue Oct 5, 2023
@kachick
Prefer Nix flake then update dprint and typescript with the new nixpk…
6647fb6 
…gs (#527)

* Prefer Nix flake and bump nixpkgs

* Bump dprint.json with old dprint

`rtx exec dprint@0.39.1 -- dprint config update --yes && rtx exec dprint@0.40.2 -- dprint fmt`

dprint/dprint-plugin-prettier#56

And removed outdated includes specifier

* Add workaround for TypeScript errors

* Remove unused deno for now (I will add in another PR

* `npm run package`

* Allow LGPL action

* Cloning submodule will done by checkout action

https://stackoverflow.com/a/70882149/1212807
@kachick kachick mentioned this issue Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kachick @dsherret