-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation failed due to ologram issue #160
Comments
@qferre
|
Fixed with
|
I think I know what caused this. It's a simple, silly bug due to the fact that I delegate the drawing of the graph to a subprocess so we can assign a maximum time. It's surprising that it has not happened before, though. Does your latest commit fix the issue ? |
Whoops, sorry, I posted my answer before I saw yours. Out of curiosity, what made you choose to use billiard specifically ? |
Because I had 3 issue (2 not reported) with multiprocessing. Everything was fixed using the magic (?) of billiard. |
Un autre problème surgit dans la doc (peut être lié à import billiard as multiprocessing dans ologram.py ?) |-- 12:24-WARNING : Converting to bed6 format (simple_07_peaks.bed). The above exception was the direct cause of the following exception: Traceback (most recent call last): |
With the command....
|
Yes, it's likely the fault of billard. I'll try to look into it today. |
I can confirm the error does not occur on the current develop branch (before using billiard) so it's likely the culprit. |
I cannot reproduce the error on my system, even when using the release/v.1.2.8 branch. |
@dputhier Could you try to run the faulty ologram command on the version which is on the develop branch (without billiard) ? If that works, I believe we can fix all this by not making "multiprocessing" an alias of billiard but calling billiard explicitly in ologram.py. This way subsequent imports will still import "multiprocessing". Otherwise, I don't really know what to do, since everything works fine on my machine (Xubuntu 20, Python 3.8.8) ... |
If it still does not work, I may be able to jury-rig something by making the "index_all_these" function pure. But I need to know exactly what causes the problem ASAP, and we will need to do it in a visioconference call since I cannot test this on my machine (since everything works fine for me) |
We can check this now by visio.
Le mar. 15 juin 2021 à 13:43, Quentin Ferré ***@***.***> a
écrit :
… If it still does not work, I may be able to jury-rig something by making
the "index_all_these" function pure. But I need to know exactly what causes
the problem ASAP, and we will need to do it in a visioconference call since
I cannot test this on my machine (since everything works fine for me)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#160 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN7CHXGSOFIXIW432TCJNTTS44GPANCNFSM46W4X5VQ>
.
--
====================================================================
Denis Puthier - Maître de Conférences
Deputy director for Education of MarMaRa Institute
Co-head of TGML (Transcriptomics & Genomics Platform Marseille Luminy)
laboratoire INSERM
TAGC/INSERM U 1090
Parc Scientifique de Luminy case 928
163, avenue de Luminy
13288 MARSEILLE cedex 09
FRANCE
Mail: ***@***.***
Tel: (National) 04 91 82 87 31 / (International) 33 4 91 82 87 31
Fax: (National) 04 91 82 87 01 / (International) 33 4 91 82 87 01
Web: https://tagc.univ-amu.fr/en/user/645
====================================================================
|
@dputhier : Can you send me a visio link ? I am available for 30 minutes. |
The text was updated successfully, but these errors were encountered: