Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #52 - Managing Doublefaced cards #62

Merged
merged 3 commits into from
Jan 2, 2018

Conversation

HerveH44
Copy link
Contributor

This pull adds

  1. show flipped face during mouseOver on doublefaced cards
  2. show the two faces of double-faced cards on main and and side zones, thanks to imageHelper popup.

@tooomm
Copy link
Contributor

tooomm commented Nov 5, 2017

Gave this another check on your beta on heroku - looks damn sweet. And works nicely 👍

@HerveH44
Copy link
Contributor Author

HerveH44 commented Nov 6, 2017

We can add it if you want!

FY, I stil didn't add any PR in the refactoring ... I guess It shouldn't take too long to rewrite the same code using JSX ( I even guess that it should take very little time ).

@tooomm
Copy link
Contributor

tooomm commented Nov 6, 2017

Ok, so this pr is up to date and ready. 👍

Maybe it's best to wait for the refactor to finish. It looks like you're actively working on it.
We don't have to include code that has to change again soon.

@dev-id dev-id merged commit da35cd7 into dr4fters:master Jan 2, 2018
@tooomm tooomm mentioned this pull request Jan 3, 2018
4 tasks
@HerveH44 HerveH44 deleted the doubleface branch February 22, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants