Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add currencies table #730

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

pedro757
Copy link
Contributor

@pedro757 pedro757 commented Nov 30, 2023

Fixes #729

@pedro757
Copy link
Contributor Author

pedro757 commented Nov 30, 2023

@dr5hn What do you think? I believe this should be a different table.

If you want to merge, is there anything else that I should modify in the repo?

Maybe this should be a many to many relation

@dr5hn dr5hn force-pushed the master branch 7 times, most recently from 414c000 to 42e0f4f Compare June 8, 2024 14:33
@dr5hn
Copy link
Owner

dr5hn commented Sep 3, 2024

@pedro757 I appreciate your pull request. The normalization aspect looks excellent. However, I suggest we maintain a standalone currencies table without modifying the countries table. This approach would make it simpler for anyone who wants to access currency data independently.

Could you please remove the changes you've made in countries table?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: separate currency table
2 participants